Skip to content

Conversation

@svdimitr
Copy link
Contributor

@svdimitr svdimitr commented Mar 25, 2021

General tasks for a new feature (delete if not applicable)

  • Check links to and from demos, demos descriptions and metadata
  • Update relevant KB articles or sample projects that may now be easier or cover the scenario that is not built-in

New Component Checklist (delete for other types of PRs)

  • - Overview article

    • General information on the purpose of the component.
    • Instruction on how to add the component to a razor component.
    • Basic configuration of the component - code snippet with a scenario that is both basic, and meaningful.
    • Provide information on the component's reference.
    • List the available features for the component and/or provide links (slugs) for the articles that explain them in details. For simpler components listing parameters might be enough, for more complex ones sections with a sentence or two that links corresponding articles might be more suitable.
    • Maybe some Example(s) - very common scenarios, notes, typical use case, etc. Not mandatory, depends on the component.
  • - Data binding article - applicable if data can be provided to the component. My be one article or a folder with several articles (examples - DropDownList and TreeView)

  • - Feature/component specific articles - those articles explain the component specific features, which do not suit in any of the before-mentioned articles. Examples of such articles are the Navigator for the Stock Chart, the Indeterminate state for the CheckBox and others.

  • - Selection article - applicable if the component exposes items selection. May be a folder.
    [ ] - Single item selection
    [ ] - Multiple item selection

  • - Templates - applicable if additional customization is allowed with Templates. Usually a folder, see the grid

  • - Events article - applicable if the component expose events.
    Examples of such events could be:

  • OnClick
  • OnChange
  • ValueChanged
  • SelectedItemsChanged
  • OnRead
  • etc.
  • Update Input Validation, Globalization, Keyboard Navigation, Accessibility Compliance articles as applicable.

  • Link from the Overview components list

@svdimitr svdimitr self-assigned this Mar 25, 2021
@svdimitr
Copy link
Contributor Author

Question:

I have added the Center Template as part of the Labels article since it is a label after all. Should I move it to a dedicated folder?

@svdimitr svdimitr requested a review from marin-bratanov March 25, 2021 16:40
@marin-bratanov
Copy link
Contributor

See my comments here #262 as well

Copy link
Contributor

@marin-bratanov marin-bratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues, see also the comments on the other PR

new MyDataModel() { SecondSeriesValue = 3, ExtraData = "third" },
new MyDataModel() { SecondSeriesValue = 2, ExtraData = "fourth" },
};
![Basic Arc Gauge](images/basic-arc-gauge.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the image so it does not have whitespace. Consider enabling the center template in this example, it looks cool. It can be an optional step in the list above.

</TelerikArcGauge>
````

## StartAngle and EndAngle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People will want to make a full circle gauge out of this. If it is possible (e.g., start angle = 0 and end angle = 360) add such an example. Otherwise, add a link to the circular gauge (could be a green tip above or below the example)


The `Format` (`string`) parameter allows you to customize the rendering of the labels by using the <a href="https://docs.microsoft.com/en-us/dotnet/standard/base-types/standard-numeric-format-strings" target="_blank">standard numeric format strings</a>. You can set the values of the labels to showcase, for example, currency, percentage, and so on.

>caption Use the Format parameter to showcase currency. The result from the code snippet below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caption says "currency" but it is percentage

* docs(circular-gauge):initial docs

* chore(gauge): screenshot fix

* chore(circular-gauge):fixing typo

Co-authored-by: Nadezhda Tacheva <ntacheva@progress.com>
Co-authored-by: Marin Bratanov <m.bratanov@gmail.com>
@svdimitr svdimitr closed this Mar 29, 2021
@marin-bratanov marin-bratanov deleted the arc-gauge-docs branch March 30, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants