Added new kb article grid-kb-conditionally-hide-command-buttons #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xristianstefanov
added
the
merge-to-production
|
Hello @xristianstefanov, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
Tsvetomir-Hr
approved these changes
Jan 23, 2025
dimodi
reviewed
Jan 23, 2025
dimodi
reviewed
Jan 23, 2025
Comment on lines
+75
to
+78
| private async Task HandleCustomButtonClick(GridCommandEventArgs args) | ||
| { | ||
| CustomCommandResult = new MarkupString(CustomCommandResult + string.Format("<br />Custom command triggered for item {0}", (args.Item as SampleData).ID)); | ||
| } |
There was a problem hiding this comment.
This can be simplified or even removed. The focus of the KB is different and doesn't require MarkupString or custom commands. You can use a built-in Delete command.
There was a problem hiding this comment.
Let that be the difference from the Incell editing demo?
dimodi
reviewed
Jan 23, 2025
dimodi
reviewed
Jan 23, 2025
dimodi
reviewed
Jan 23, 2025
|
Here you are the link to your PR to production: 2725 |
github-actions
bot
deleted the
new-kb-grid-kb-conditionally-hide-command-buttons-cf7bcd9c885547e5be5bc421dec101cc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.