kb(grid):add kb for saving state in wasm #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does it have to be a controller? You can save to localStorage in the browser. I think it is worth mentioning at least. |
Contributor
marin-bratanov
left a comment
marin-bratanov
left a comment
There was a problem hiding this comment.
I recommend mentioning this in the KB and in the readme of the project. Consider adding a sample in the project for that too, it is just a few lines of code in a new service.
marin-bratanov
suggested changes
Aug 25, 2021
Contributor
marin-bratanov
left a comment
marin-bratanov
left a comment
There was a problem hiding this comment.
A little nitpicky, but I think this is a good example of clear and precise language that we should strive for.
marin-bratanov
approved these changes
Sep 11, 2021
dimodi
pushed a commit
that referenced
this pull request
Sep 13, 2021
* kb(grid):add kb for saving state in wasm * chore(grid):added fixes as per comment * chore(grid): fixed description * chore(grid):improved description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.