Skip to content

Conversation

@dimodi
Copy link
Contributor

@dimodi dimodi commented Sep 10, 2021

No description provided.

@dimodi dimodi requested a review from a team September 10, 2021 14:33
@dimodi dimodi self-assigned this Sep 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2021

Hello @dimodi,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create pr to production

Copy link
Contributor

@marin-bratanov marin-bratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not combine the cases into one rule that both sets padding and right-align and add a comment that the padding is for the sorting and filtering icons, and if they don't use these features they can simply remove that line? I'd propose such a simple snippet as the first snippet and if we want to be exhaustive we can add the second CSS snippet with the many cases.

@dimodi
Copy link
Contributor Author

dimodi commented Sep 13, 2021

Refactored the CSS code to contain fewer CSS rules.

@dimodi dimodi merged commit aa54fa8 into master Sep 13, 2021
@dimodi dimodi deleted the grid-right-align branch September 13, 2021 14:14
@github-actions
Copy link
Contributor

Automatic cherry-pick & PR to production failed. Ping @telerik/blazor-admins for manual cherry-pick and push to production.

dimodi added a commit that referenced this pull request Sep 13, 2021
* Add Grid right align header cells KB

* Refactor CSS rules

* Refactor CSS rules 2

Co-authored-by: Dimo Dimov <dimo@Dimos-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants