Theme Swatches docs #532
Merged
Theme Swatches docs #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello @ntacheva, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
reviewed
Oct 22, 2021
dimodi
requested changes
Oct 22, 2021
Contributor
dimodi
left a comment
dimodi
left a comment
There was a problem hiding this comment.
Tips:
- introduce swatch as a term somewhere in the beginning
- explain what a base/main theme is
- the note about theme version in the CDN URL is a bit confusing
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
dimodi
approved these changes
Oct 25, 2021
ntacheva
added a commit
that referenced
this pull request
Oct 26, 2021
* docs(swatches): article for the swatches of the buil-in themes * Update styling-and-themes/theme-swatches.md Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * Update styling-and-themes/theme-swatches.md Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * Update styling-and-themes/theme-swatches.md Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * Update styling-and-themes/theme-swatches.md Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * Update styling-and-themes/theme-swatches.md Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com> * docs(themes):swatches article improvements Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.