Improvement for "Conditionally Hide Hierarchical Grid Expand Button" article #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the CSS class "no-children" was inverted. I was having a "null" issue because the row didn't have childs. The error was style showing if I clicked on the cell after hidding the expand icon. To fix this, I added a CSS class to set the visibility of the .k-hierarchy-cell to "hidden" so the click is not triggered when clicking in the cell.
Contributor
|
Hi @mp9007, Thank you for your feedback! The CSS class "no-children" was indeed inverted, so we fixed that. As for hiding the cells that do not have expand icons - this could break the layout, so we consider a safer approach would be to stop the pointer events of these cells. I have already submitted a PR with both of the changes, so I am hereby closing the current one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the CSS class "no-children" was inverted.
I was having a "null" issue because the row didn't have childs. The error was style showing if I clicked on the cell after hidding the expand icon.
To fix this, I added a CSS class to set the visibility of the .k-hierarchy-cell to "hidden" so the click is not triggered when clicking in the cell.