docs(calendar):Add TopView property #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xristianstefanov
commented
Jun 5, 2022
xristianstefanov
commented
- Added the TopView property near the BottomView description
- Example improved by setting the TopView there as well
dimodi
requested changes
Jun 6, 2022
Contributor
dimodi
left a comment
dimodi
left a comment
There was a problem hiding this comment.
I had to read the docs two times and experiment with TopView to make sure I understand what it does. Just adding TopView in the existing text does not produce technically correct text, for example: "Once the user reaches this TOP or bottom view, CLICKING THE ITEMS SELECTS THEM and does NOT navigate to a more detailed view."
We should explain better that:
- BottomView sets the greatest level of detail
- TopView sets the least level of detail, i.e. greatest level of date aggregation
- If View is not set, the Calendar will initially display its BottomView.
- Mention the default values of TopView and BottomView.
dimodi
reviewed
Jun 20, 2022
dimodi
reviewed
Jun 20, 2022
dimodi
approved these changes
Jun 20, 2022
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.