Skip to content

fix: Incorrect scroll offset on initial page load and when starting from the top #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2020
Merged

fix: Incorrect scroll offset on initial page load and when starting from the top #106

merged 3 commits into from
Aug 7, 2020

Conversation

@dimodi
Copy link
Collaborator

@dimodi dimodi commented Jul 9, 2020 •
edited
Loading

Related to issue #93.

Changes:

  • increased the initial scrolling setTimeout from 100 to 200 to tackle Safari
  • changed a header element height constant, after layout changes
  • took into account the breadcrumbs element when calculating the correct scroll offset
  • enhanced the scroll offset calculation for the API section

@imtodor imtodor self-requested a review July 14, 2020 10:50
@imtodor imtodor merged commit c29c54e into master Aug 7, 2020
@imtodor imtodor deleted the scroll-bug-from-top branch August 7, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imtodor imtodor Awaiting requested review from imtodor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimodi @imtodor