Skip to content

fix(settings): add check for empty settings values #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix(settings): add check for empty settings values #12

merged 2 commits into from
Feb 20, 2025

Conversation

@iamprecieee
Copy link
Collaborator

@iamprecieee iamprecieee commented Feb 20, 2025

  • make no change to data if settings value is empty
  • update telex test to handle cases of empty value data and include slack url
  • remove slack_url field from config

@iamprecieee
chore(slack): updated slack url retrieval functionality
79a5855 
- added field for slack webhook url to json settings
- updated analyzer and telex endpoint to retrieve slack url from settings
- updated readme to reflect changes
@iamprecieee
fix(settings): add check for empty settings values
1318930 
- make no change to data if settings value is empty
- update telex test to handle cases of empty value data and include slack url
- remove slack_url field from config
@iamprecieee iamprecieee merged commit 2f1fe9a into staging Feb 20, 2025
@iamprecieee iamprecieee deleted the chore/slack branch February 20, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iamprecieee