Skip to content

fix: Converts Approved Review Count to string #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rickardl merged 2 commits into from
Oct 20, 2020
Merged

fix: Converts Approved Review Count to string #231

rickardl merged 2 commits into from
Oct 20, 2020

Conversation

@isaacsanders
Copy link
Contributor

@isaacsanders isaacsanders commented Oct 20, 2020

Fixes #229

@isaacsanders isaacsanders requested a review from a team as a code owner October 20, 2020 13:53
@isaacsanders isaacsanders changed the title fix: Conversts Approved Review Count to string fix: Converts Approved Review Count to string Oct 20, 2020
@isaacsanders isaacsanders force-pushed the fix/strconv-approved-review-count branch from d031c34 to ad669ca Compare October 20, 2020 13:53
@isaacsanders
Copy link
Contributor Author

isaacsanders commented Oct 20, 2020

@rickardl @rorymalcolm

@rickardl rickardl self-assigned this Oct 20, 2020
rickardl
rickardl approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@rickardl rickardl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickardl rickardl merged commit 2ab0f31 into telia-oss:master Oct 20, 2020
@rickardl
Copy link
Contributor

rickardl commented Oct 20, 2020

@isaacsanders Great work

@isaacsanders isaacsanders deleted the fix/strconv-approved-review-count branch October 20, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rickardl rickardl rickardl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rickardl rickardl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resource Checks Failing on Unmarshalling

2 participants

@isaacsanders @rickardl