Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Improve sidecred logging#92

Merged
myi6902 merged 5 commits into
masterfrom
improve-logging
Dec 23, 2022
Merged

Improve sidecred logging#92
myi6902 merged 5 commits into
masterfrom
improve-logging

Conversation

@mansn-at-telia
Copy link
Copy Markdown
Contributor

@mansn-at-telia mansn-at-telia commented Dec 22, 2022

This PR adds the following,

  • A golang context object to calls, for future timeout handling, and carrying request data.
  • A logger to the context object, for easier logging in all the code.
  • A stats object to the context object, for easier collection of statistics.
  • A trace_id to the logs, for connecting the logs together in datadog.

@mansn-at-telia mansn-at-telia requested review from a team and itsdalmo as code owners December 22, 2022 14:03
myi6902
myi6902 approved these changes Dec 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@myi6902 myi6902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myi6902 myi6902 merged commit 47f2cf1 into master Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itsdalmo itsdalmo Awaiting requested review from itsdalmo

1 more reviewer

@myi6902 myi6902 myi6902 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mansn-at-telia @myi6902