Remembering pagination state for tx table #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-mainnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for teloscan-stage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
donnyquixotic
suggested changes
Jan 26, 2023
Contributor
There was a problem hiding this comment.
We should handle this in the router by incorporating query/filter params as part of routing (e.g. /<address>?page=3 ) to track pagination instead of using state. This allows history tracking and avoids unintended behavior. For instance, If you navigate to a different page and click on an address in the table, the page state is applied where it shouldn't be.
ezra-sg
reviewed
Jan 27, 2023
ezra-sg
reviewed
Jan 27, 2023
Deploying with
|
| Latest commit: |
d26b1bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00fc1722.teloscan.pages.dev |
| Branch Preview URL: | https://293-facilitate-user-navigati-7ao3.teloscan.pages.dev |
…ck-of-where-they-were-1
donnyquixotic
approved these changes
Jan 30, 2023
donnyquixotic
deleted the
293-facilitate-user-navigation-by-keeping-track-of-where-they-were-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293
Description
When you find a special transaction from the table and you follow the link and then come back to the table, the pagination is lost and you must start from the first page again which leads to a terrible user experience.
This PR makes the table save in local storage the last pagination state and recovers it every time the table is used again.
Test scenarios
To recreate this new behavior you must:
Checklist: