Formatting issue with mago formatter

[gturpin-dev]

Tempest version

dev-main

PHP version

8.4

Operating system

Windows

Description

Mago formatted me something I found weird so I wanted to push it here just in case 😄

Steps to reproduce

Original :

$providerType = BuiltInOAuthProvider::fromProviderClass($class->getName()) ?? throw new OAuthException(sprintf('No built-in OAuth2 provider found for class: "%s"', $class->getName()));

After formatting :

$providerType = BuiltInOAuthProvider::fromProviderClass($class->getName()) ??
throw new OAuthException(sprintf('No built-in OAuth2 provider found for class: "%s"', $class->getName()));

Let me know if it's just me, but I found this line return a bit weird for readability

I've used composer fmt

[xHeaven]

When stuff like this happens, I prefer pressing a few enters - specifically between function arguments. The original is way too long, and the formatted might feel weird, however, this could be better:

$providerType = BuiltInOAuthProvider::fromProviderClass(
    $class->getName(),
) ?? throw new OAuthException(sprintf(
    'No built-in OAuth2 provider found for class: "%s"',
    $class->getName(),
));

With that in mind, though, I definitely wouldn't classify this as a bug - especially because I couldn't make Mago format it like it did for you. This is what it did for me:

$providerType = BuiltInOAuthProvider::fromProviderClass($class->getName()) ?? throw new OAuthException(sprintf(
    'No built-in OAuth2 provider found for class: "%s"',
    $class->getName(),
));

[innocenzi]

FYI, I'm currently upgrading Mago to the latest beta—this will be fixed in the process