Skip to content

feat(console): improve completion support#2015

Merged
xHeaven merged 8 commits intotempestphp:3.xfrom
xHeaven:completion
Mar 7, 2026
Merged

feat(console): improve completion support#2015
xHeaven merged 8 commits intotempestphp:3.xfrom
xHeaven:completion

Conversation

@xHeaven
Copy link
Member

@xHeaven xHeaven commented Mar 3, 2026

Closes #2013.

@xHeaven xHeaven requested review from brendt and innocenzi as code owners March 3, 2026 11:17
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Benchmark Results

Comparison of completion against 3.x (2e6d512efc0993d258f3c32b4fb8dfb1f05d866d).

Open to see the benchmark results

No benchmark changes above ±5%.

Generated by phpbench against commit 12fff00

@tamdaz
Copy link

tamdaz commented Mar 5, 2026

Apparently, the shell has detected the completion functions but it is not displaying all the commands. When I type ./tempest, the autocompletion does not display on the terminal.

image
tempest.completion.mp4

In the file ~/.config/fish/config.fish, I added the source allowing completion functions to be taken into account for Tempest.

if status is-interactive
    source $HOME/.tempest/completion/tempest.fish # <--- added here
    # ...
end

If you have successfully got autocomplete on a different machine, don't hesitate to share your method.

@xHeaven
Copy link
Member Author

xHeaven commented Mar 6, 2026

Apparently, the shell has detected the completion functions but it is not displaying all the commands. When I type ./tempest, the autocompletion does not display on the terminal.

image
tempest.completion.mp4

In the file ~/.config/fish/config.fish, I added the source allowing completion functions to be taken into account for Tempest.

if status is-interactive

    source $HOME/.tempest/completion/tempest.fish # <--- added here

    # ...

end

If you have successfully got autocomplete on a different machine, don't hesitate to share your method.

Did you run ./tempest completion:generate to generate the completion file for your project? I've installed a fresh fish shell on my macOS, added the source line and everything works just fine.
Any chance you could hop in to a thread on Discord to try and debug this?

@tamdaz
Copy link

tamdaz commented Mar 6, 2026

Yes, I did indeed run this command to generate the completion file. I can show you this issue in detail on Discord. 👍

EDIT: For the moment, this fish file has been generated from the project you forked.

@xHeaven
Copy link
Member Author

xHeaven commented Mar 6, 2026

Yes, I did indeed run this command to generate the completion file. I can show you this issue in detail on Discord. 👍

EDIT: For the moment, this fish file has been generated from the project you forked.

I've opened a thread on Discord, feel free to text me when you're available.

@xHeaven xHeaven changed the title feat(console): add fish completion support feat(console): improve completion support Mar 7, 2026
@xHeaven xHeaven merged commit 8b53d5b into tempestphp:3.x Mar 7, 2026
81 of 82 checks passed
@xHeaven xHeaven deleted the completion branch March 7, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the completion compatible with fish shell

2 participants