feat(support): with and without methods for manipulatesarray#2094
Open
iamdadmin wants to merge 2 commits intotempestphp:3.xfrom
Open
feat(support): with and without methods for manipulatesarray#2094iamdadmin wants to merge 2 commits intotempestphp:3.xfrom
iamdadmin wants to merge 2 commits intotempestphp:3.xfrom
Conversation
iamdadmin
added a commit
to iamdadmin/tempest-framework
that referenced
this pull request
Mar 31, 2026
innocenzi
requested changes
Mar 31, 2026
Member
innocenzi
left a comment
There was a problem hiding this comment.
I like the methods, but not the names; I don't think generic method names are helpful and I'd like to see more specific ones.
These are essentially "filter" methods, so maybe with should be an update to the existing filter where it accepts an array, and without should be a new reject method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested from #2092 - introduces convenience methods
->withand->withoutfor ManipulatesArray, and tests.Usage examples from the test: