refactor(generation): remove tempest/container dependency#2117
Merged
Conversation
|
#2116 merged |
innocenzi
force-pushed
the
refactor/generation-container
branch
from
2a9ef85 to
b9b7191
Compare
|
@brendt would love to see this merged, thanks! |
Member
|
Sorry for being late! |
Member
|
It's now merged, tagging later today 👍 |
thanks! |
Member
|
Tagged in 3.11.0 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2116, will update this PR when merged
What
This pull request removes the dependency of
tempest/generationontempest/containerby using PSR-11 instead. This makes the package usable outside of Tempest in applications that user other containers.Why
With
tempest/containeras a dependency, Discovery will find many discoveries depending on Tempest's own container, which is obviously not registered (and should not be alongside another container), so it will fail at theBootDiscoverystep.I'm thinking that for all packages that we want to be usable standalone, we probably want to do the same.