Skip to content

fix(core): report deprecations without throwing#2126

Merged
brendt merged 1 commit into3.xfrom
fix/dont-throw-deprecations
Apr 23, 2026
Merged

fix(core): report deprecations without throwing#2126
brendt merged 1 commit into3.xfrom
fix/dont-throw-deprecations

Conversation

@innocenzi
Copy link
Copy Markdown
Member

Closes #2124

This pull request improves our error handling to:

  • report notices/deprecations/warnings without throwing
  • ignore suppressed errors (with @)
  • add some tests regarding all of that

That should be a more natural behavior, but we might need to iterate on that (make it configurable?)

@innocenzi innocenzi requested a review from brendt as a code owner April 22, 2026 16:44
@github-actions
Copy link
Copy Markdown

Benchmark Results

Comparison of fix/dont-throw-deprecations against 3.x (43592b7c5788504824a332fc13abeec9a4390364).

Open to see the benchmark results
Benchmark Set Mem. Peak Time Variability
ViewRenderBench(benchControlFlow) - 44.432mb 0.00% 710.544μs -5.37% ±2.30% -27.59%
ViewRenderBench(benchViewComponent) - 69.668mb 0.00% 1.403ms -6.66% ±1.81% -46.72%
DiscoveryScanBench(benchFullDiscoveryScan) - 24.419mb +0.01% 17.749ms +8.13% ±0.74% -58.47%

Generated by phpbench against commit 863759e

@brendt
Copy link
Copy Markdown
Member

brendt commented Apr 23, 2026

That should be a more natural behavior, but we might need to iterate on that (make it configurable?)

Sounds like a good thing to have, although outside the scope of this PR

@brendt brendt merged commit a75b008 into 3.x Apr 23, 2026
76 checks passed
@brendt brendt deleted the fix/dont-throw-deprecations branch April 23, 2026 06:03
@brendt
Copy link
Copy Markdown
Member

brendt commented Apr 23, 2026

Thanks for fixing this so quickly btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warnings and deprecations get converted to uncatchable ErrorExceptions

2 participants