Skip to content

Conversation

@bYemma
Copy link
Contributor

@bYemma bYemma commented Sep 6, 2024

When the extract part is in an isolated method, variables from the resolveContent method can be reused in the view file.

Conflicts with variables like $view or $path e.g. are prevented. Only $_path and $_data are reserved as a minimum.

When the extract part is in an isolated method, variables from the resolveContent method can be reused in view file.

Conflicts with variables like `$view` or `$path` e.g. are prevented. Only `$_path` and `$_data` are reserved as a minimum.
@brendt brendt merged commit aeb33dc into tempestphp:main Sep 7, 2024
@brendt
Copy link
Member

brendt commented Sep 7, 2024

Nice, thanks!

@coveralls
Copy link

coveralls commented Sep 7, 2024

Pull Request Test Coverage Report for Build 10742648156

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 77.514%

Totals Coverage Status
Change from base Build 10720952437: -0.1%
Covered Lines: 4285
Relevant Lines: 5528

💛 - Coveralls

@bYemma bYemma deleted the isolate-extract-method branch September 8, 2024 09:03
Blurazzle pushed a commit to Blurazzle/tempest-framework that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants