fix: Error on missing S3 files, do not write error data to disk #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
fix/xml-results
branch
from
9712778 to
603b0c3
Compare
effigies
force-pushed
the
fix/xml-results
branch
from
603b0c3 to
55e4569
Compare
effigies
force-pushed
the
fix/xml-results
branch
from
214205d to
39c689a
Compare
Contributor
Author
|
@mgxd Would you mind having a look? |
mgxd
approved these changes
Oct 8, 2025
Contributor
mgxd
left a comment
mgxd
left a comment
There was a problem hiding this comment.
Looks reasonable and helpful! A few suggestions - otherwise LGTM
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
effigies
added a commit
that referenced
this pull request
Oct 21, 2025
25.1.0 (October 21, 2025) New feature release in the 25.1 series. This release introduces a new ``TemplateFlowClient`` class that provides the functionality previously exposed in ``templateflow.api``. ``templateflow.api`` is now a thin wrapper around a global instance of ``TemplateFlowClient``, so existing code using ``templateflow.api`` should continue to work as before. These changes allow multiple independent clients to coexist in the same Python process, as well as defer loading of data from the filesystem until it is requested, significantly improving import time. * RF: Factor TemplateFlow into Cache and Client classes (#149) * FIX: Error on missing S3 files, do not write error data to disk (#148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At times the S3 URLs can become unresponsive, presumably due to an incomplete export. Currently templateflow handles this by treating the XML response as the file contents. Future calls continue to pick that up, even after the export has been fixed.
This PR does two things:
Paths for prior run error outputs and truncate the files back to 0 bytes before continuing in theget()logic, to allow these files to be treated as missing.