TST: Fix expected bib results #83
Conversation
mgxd
force-pushed
the
fix/citation-tests
branch
2 times, most recently
from
bd16269 to
3136c6a
Compare
mgxd
force-pushed
the
fix/citation-tests
branch
from
3136c6a to
384ba60
Compare
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 87.55% 89.77% +2.22%
==========================================
Files 5 5
Lines 217 225 +8
==========================================
+ Hits 190 202 +12
+ Misses 27 23 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
actually before releasing, I'd like to ensure this was the intended behavior (cc @oesteban) |
| \tauthor = {Vladimir Fonov and Alan C. Evans and Kelly Botteron and C. Robert \ | ||
| Almli and Robert C. McKinstry and D. Louis Collins}, | ||
| \ttitle = {Unbiased average age-appropriate atlases for pediatric studies}, | ||
| \tjournal = {{NeuroImage}} |
There was a problem hiding this comment.
I'm a little nervous that doi.org are changing their responses. They used to generate Lastname_year identifiers, and now these seem to be only year.
We probably can have a regexp to override whatever ID they generate to the template name.
However, I'm less happy with the references not having a journal entry. Before we go ahead we need to understand why these are changing.
There was a problem hiding this comment.
Yes, looking more into it, it does seem like a bug. Looks like crossref should have a fix out today, dunno if doi.org will follow suit but we could always switch over to crossref since they have an API as well.
There was a problem hiding this comment.
doi.org just redirects POST requests over to crossref
2 participants
No description provided.