Update protos with account get/update operations #181
Merged
+3,538
−1,323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not super up-to-date with the status of Cloud protos. @anekkanti / @cretz, do you know if this is safe to upgrade? Is the change from string to enums implemented? |
anekkanti
previously approved these changes
Oct 16, 2024
bergundy
approved these changes
Oct 17, 2024
Contributor
Author
|
@bergundy thanks for the approval! Would you mind cutting a new release? |
Member
|
Hey, I'm just verifying with our Cloud team that we're good to release and will get back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
proto/api-cloudmakewhich updated the account update/get operations in addition to migration from string values to enumsWhy?
How did you test it?
Potential risks