Get latest cloud apis. #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Oct 17, 2024
Member
There was a problem hiding this comment.
Since the protos are not combined, I think this needs to also be done at:
- https://github.com/temporalio/sdk-core/tree/master/sdk-core-protos/protos for the
api_cloud_upstreamfolder (see https://github.com/temporalio/sdk-core?tab=readme-ov-file#proto-files) - https://github.com/temporalio/sdk-java/tree/master/temporal-serviceclient/src/main for the
protocloudsubmodule
Member
|
Seems this never got followed up on. Closing in favor of #190. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Pull in the latest changes from api-cloud protos.
Why?
How did you test it?
Potential risks