Skip to content

Fix proto generation for new subdirectories#248

Merged
rkannan82 merged 2 commits intomasterfrom
kannan/fix-makefile-mv
Apr 10, 2026
Merged

Fix proto generation for new subdirectories#248
rkannan82 merged 2 commits intomasterfrom
kannan/fix-makefile-mv

Conversation

@rkannan82
Copy link
Copy Markdown
Contributor

@rkannan82 rkannan82 commented Apr 10, 2026

What

Replace mv -f with cp -rf when flattening generated proto output, so new subdirectories (e.g. nexusservices) don't cause the build to fail.

Why

mv cannot merge directories — when a new proto subdirectory is added to the api repo, mv fails with "cannot overwrite: Directory not empty". This is what's breaking the Update Proto workflow.

Example error:

Submodule path 'proto/api': checked out '67150b14e0509210bf250960bd3278a4509e091c'
Deleting generated go files...
Installing protoc plugin
Compile for go-gRPC...
mv: cannot overwrite './nexusservices': Directory not empty
make: *** [Makefile:56: go-grpc] Error 1
Error: Process completed with exit code 2.

How did you test it?

Triggered a test run and it succeeded.
https://github.com/temporalio/api-go/actions/runs/24223347639

  gh workflow run update-proto.yml --repo temporalio/api-go --ref kannan/fix-makefile-mv \
    -f branch=kannan/fix-makefile-mv \
    -f commit_author="rkannan82" \
    -f commit_author_email="kannan@temporal.io" \
    -f commit_message="Test: verify proto generation with mv fix"

🤖 Generated with Claude Code

The `mv -f` command cannot merge directories — it fails when the
destination directory already exists. Replace with `cp -rf` so that
new proto subdirectories (e.g. nexusservices) are handled correctly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rkannan82 rkannan82 requested review from a team as code owners April 10, 2026 01:52
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 10, 2026

CLA assistant check
All committers have signed the CLA.

@rkannan82 rkannan82 requested a review from carlydf April 10, 2026 02:30
@rkannan82 rkannan82 force-pushed the kannan/fix-makefile-mv branch from a3d5abf to abff50d Compare April 10, 2026 02:33
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rkannan82 rkannan82 enabled auto-merge (squash) April 10, 2026 02:34
@rkannan82 rkannan82 merged commit e314f09 into master Apr 10, 2026
4 checks passed
@rkannan82 rkannan82 deleted the kannan/fix-makefile-mv branch April 10, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants