Conversation
|
|
stephanos
force-pushed
the
stephanos/sano
branch
from
ad745f6 to
01e0d5e
Compare
Signed-off-by: Stephan Behnke <stephanos@users.noreply.github.com>
stephanos
force-pushed
the
stephanos/sano
branch
from
01e0d5e to
ee93455
Compare
stephanos
commented
Apr 23, 2026
Comment on lines
+541
to
+553
| {{if and (eq $type "*workflowservice.DescribeNexusOperationExecutionResponse") (eq . "Result")}} | ||
| if o.GetResult() != nil { | ||
| result := o.GetResult() | ||
| if err := visitPayload(ctx, options, o, concState, &result); err != nil { return err } | ||
| o.Outcome = &workflowservice.DescribeNexusOperationExecutionResponse_Result{Result: result} | ||
| } | ||
| {{else if and (eq $type "*workflowservice.PollNexusOperationExecutionResponse") (eq . "Result")}} | ||
| if o.GetResult() != nil { | ||
| result := o.GetResult() | ||
| if err := visitPayload(ctx, options, o, concState, &result); err != nil { return err } | ||
| o.Outcome = &workflowservice.PollNexusOperationExecutionResponse_Result{Result: result} | ||
| } | ||
| {{else}} |
Contributor
Author
There was a problem hiding this comment.
This manual change; everything else is generated.
We have a follow-up ticket filed to find a non-stopgap solution for this.
S15
approved these changes
Apr 23, 2026
stephanos
commented
Apr 23, 2026
Contributor
Author
There was a problem hiding this comment.
Updated to latest api
THardy98
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Patching
cmd/proxygenerator/interceptor.goto generate valid code forDescribeNexusOperationExecutionResponseandPollNexusOperationExecution.Why?
Fails otherwise.
How did you test it?
Builds.
Potential risks
Limited to new Nexus APIs.