Add revision_number to DeclinedTargetVersionUpgrade#762
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ShahabT
approved these changes
Apr 16, 2026
Sushisource
approved these changes
Apr 17, 2026
spkane31
pushed a commit
that referenced
this pull request
Apr 24, 2026
<!-- Describe what has changed in this PR --> - Added `revision_number` to `DeclinedTargetVersionUpgrade`, which already took in a deployment version. - Recap about what `DeclinedTargetVersionUpgrade` does: the main intention of this field was to "remember" which target version we have rejected when a pinned workflow declines to AU when CAN'ing. However, you could have matching partitions send you back stale target deployment versions, and we don't want to "bounce back" and CAN our pinned workflows when they see such a stale version. For that very purpose, we resort to now store the revision number here. <!-- Tell your future self why have you made these changes --> - I explained it above <!-- Are there any breaking changes on binary or code level? --> - None, changes are additive. - Also, no changes required from the SDK perspective <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> temporalio/temporal#9895 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revision_numbertoDeclinedTargetVersionUpgrade, which already took in a deployment version.DeclinedTargetVersionUpgradedoes: the main intention of this field was to "remember" which target version we have rejected when a pinned workflow declines to AU when CAN'ing. However, you could have matching partitions send you back stale target deployment versions, and we don't want to "bounce back" and CAN our pinned workflows when they see such a stale version. For that very purpose, we resort to now store the revision number here.temporalio/temporal#9895