add on conflict options for standalone activities#764
Merged
Conversation
bergundy
approved these changes
Apr 14, 2026
maciejdudko
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new OnConflictOptions message to temporal.api.activity.v1 and a corresponding on_conflict_options field to StartActivityExecutionRequest.
Why?
When StartActivityExecution uses ACTIVITY_ID_CONFLICT_POLICY_USE_EXISTING and a matching activity is already running, the caller needs a way to specify what should be attached to the existing activity (request ID, completion callbacks, links). This mirrors the existing OnConflictOptions for workflows (temporal.api.workflow.v1.OnConflictOptions on StartWorkflowExecutionRequest) but is specific to the activity domain.