feat: add metrics configuration to soak-test deployment#22
Merged
robholland merged 1 commit intotemporalio:mainfrom Sep 25, 2025
Merged
feat: add metrics configuration to soak-test deployment#22robholland merged 1 commit intotemporalio:mainfrom
robholland merged 1 commit intotemporalio:mainfrom
Conversation
Contributor
Author
|
I can't sign the CLA (Version selector/field is empty). 🙁 |
Collaborator
|
Can you try the CLA thing again? It's a bit flakey unfortunately :( |
Contributor
Author
|
It's done! |
robholland
approved these changes
Sep 25, 2025
Collaborator
|
Merged and released new chart version, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This patch adds a
metricnamed port and aPROMETHEUS_ENDPOINTenvironment variable to the soak-test deployment.Why?
I am trying to follow this blog post https://temporal.io/blog/scaling-temporal-the-basics to scale up my Temporal Service.
Unfortunately, I wasn't able to collect
StartExecutionWorkflowlatencies. I found that the deployment configuration was missing both ametricnamed port and aPROMETHEUS_ENDPOINTenvironment variable, which explained why I wasn't collecting any metric from this deployment.Checklist
This is a before/after view 🙂 we notice that we start collecting
StartExecutionWorkflowrequest latencies.