Skip to content

Fix flakey test by disabling EC2 metadata lookup in test case #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaptersix merged 3 commits into from
Apr 30, 2026
+4 −0
Merged

Fix flakey test by disabling EC2 metadata lookup in test case #1005

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d2729a
Disable EC2 metadata lookup in worker deployment error test
kevinawoo Apr 29, 2026
b6f3437
Merge branch 'main' into codex/disable-aws-imds-worker-deployment-test
chaptersix Apr 30, 2026
3506b6d
Merge branch 'main' into codex/disable-aws-imds-worker-deployment-test
chaptersix Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/temporalcli/commands.worker.deployment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,6 +1199,10 @@ func (s *SharedServerSuite) TestCreateWorkerDeploymentVersion_EmptyComputeConfig
}

func (s *SharedServerSuite) TestCreateWorkerDeploymentVersion_Errors() {
// Keep the fake AWS validation case local; otherwise the SDK tries EC2 IMDS
// during credential resolution and waits on network retries.
s.T().Setenv("AWS_EC2_METADATA_DISABLED", "true")

deploymentName := uuid.NewString()
taskQueue := uuid.NewString()

Expand Down
Loading