Fix help with value flags#1006
Merged
chaptersix merged 5 commits intotemporalio:mainfrom Apr 30, 2026
Merged
Conversation
kevinawoo
changed the title
chaptersix
reviewed
Apr 29, 2026
Comment on lines
+38
to
+42
| foundCmd.InitDefaultHelpFlag() | ||
| cliParseArgs, cliPassArgs, extArgs := groupArgs(foundCmd, remainingArgs) | ||
| if findErr == nil && !slices.ContainsFunc(extArgs, isPosArg) { | ||
| return nil, false | ||
| } |
Contributor
There was a problem hiding this comment.
nit: fix comment alignment
add back the comments removed on 34 (in the correct location)
add a comment on why InitDefaultHelpFlag() is being called
When --help/-h appears after positional args in the extension dispatch path, route it to extArgs so it gets forwarded to the extension binary. This prevents the help flag from being intercepted by the parent command.
Verify that built-in help is shown (not extension invoked) when --help is combined with value flags like --address and --namespace, even when a matching extension exists on PATH.
chaptersix
approved these changes
Apr 30, 2026
davidporter-id-au
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--helpcombined with--addressand--namespaceRoot Cause
Extension preflight checked raw remaining args with a string-prefix heuristic. Values for known flags, such as
123in--address 123, looked like positional extension args, so the preflight parsed--helpbefore Cobra had registered the default help flag and surfacedpflag: help requestedas a real error.Fixes #1003.
Validation
go run ./cmd/temporal workflow list --address 123 --helpgo test ./internal/temporalcli -run 'TestHelp|TestExtension' -count=1go test ./internal/temporalcli -count=1