Fix mismatched go versions (and AS casing)#702
Merged
cretz merged 1 commit intotemporalio:mainfrom Oct 31, 2024
LeeBrotherston:fix-go-version
Merged
Fix mismatched go versions (and AS casing)#702cretz merged 1 commit intotemporalio:mainfrom LeeBrotherston:fix-go-version
cretz merged 1 commit intotemporalio:mainfrom
LeeBrotherston:fix-go-version
Conversation
Dockerfile was using golang:1.22-bookworm as the builder image, but go.mod requires >= 1.23, and so the docker image would not build. Also fixed a complaint that 'AS' was lowercase when 'FROM' is uppercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
golang:1.22-bookwormtogolang:1.23-bookwormin theDockerfileASstatement to match the rest of theDockerfileWhy?
golang:1.22-bookwormas the builder image, butgo.modrequires>= 1.23, and so the docker image build fails.ASkeyword was causing a (non fatal) build error in DockerChecklist
Closes n/a
How was this tested:
docker build .the original version, observe the errors...docker build .this version and observe that these errors are not presentno.