Skip to content

Conversation

@carlydf
Copy link
Contributor

@carlydf carlydf commented Jan 21, 2026

What was changed

Update server to v1.30.0-148.2
Update API to v1.60.0
Update SDK accordingly
Change BuildId -> BuildID for new SDK
Cherry-pick PR from main where I fixed versioning override tests so that they would work with the new server, which requires that a version exists before overriding a workflow to that version.

Why?

To make way for other PRs for Versioning GA that require the latest server version.

Checklist

  1. Closes

  2. How was this tested:
    Built locally
    If CI tests pass I think this is ok

  3. Any docs updates needed?

carlydf and others added 2 commits January 21, 2026 13:10
…for Pinned Override Version (#905)

<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR! 
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->

<!--- For ALL Contributors 👇 -->

## What was changed
- Create versions before using them in a Pinned Versioning Override
- Require Deployment Name and Build ID flags to be set if override is
Pinned. I'm not sure how this worked before, but I don't think we need
to support optional deployment name.

## Why?
So that CLI works with latest version of server.

## Checklist
<!--- add/delete as needed --->

1. Closes <!-- add issue number here -->

2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->

3. Any docs updates needed?
<!--- update README if applicable
      or point out where to update docs.temporal.io -->
@carlydf carlydf requested review from a team as code owners January 21, 2026 21:13
@cretz
Copy link
Member

cretz commented Jan 21, 2026

Cherry-pick PR from main where I fixed versioning override tests so that they would work with the new server, which requires that a version exists before overriding a workflow to that version.

Would suggest merging main into next-server (understood if a bit difficult due to large main changes wrt cliext and such, but valuable to do anyways IMO)

I agree, but ACT team is going to handle that so I don't have to be blocked on it.

@carlydf carlydf merged commit 276d1ba into next-server Jan 21, 2026
10 of 12 checks passed
@carlydf carlydf deleted the cdf/update-server branch January 21, 2026 22:19
chaptersix added a commit to chaptersix/temporal-cli that referenced this pull request Jan 23, 2026
- Remove sqlite version pinning test (matches next-server PR temporalio#881)
- Add sleep for version registration in reset tests (matches next-server PR temporalio#908)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants