temporal worker deployment create|create-version#990
Merged
chaptersix merged 2 commits intotemporalio:mainfrom Apr 22, 2026
Merged
temporal worker deployment create|create-version#990chaptersix merged 2 commits intotemporalio:mainfrom
temporal worker deployment create|create-version#990chaptersix merged 2 commits intotemporalio:mainfrom
Conversation
jaypipes
force-pushed
the
jaypipes/serverless
branch
2 times, most recently
from
32f6754 to
e943fca
Compare
chaptersix
reviewed
Apr 21, 2026
| sigs.k8s.io/yaml v1.6.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/temporalio/cli/cliext => ./cliext |
Contributor
There was a problem hiding this comment.
nit: Ideally there's no change in this file.
chaptersix
approved these changes
Apr 21, 2026
jaypipes
force-pushed
the
jaypipes/serverless
branch
from
e943fca to
0ad32e3
Compare
|
We need to bump the ui-server dependency to 2.48.4 This way the dev server will have feature parody with the CLI |
jaypipes
force-pushed
the
jaypipes/serverless
branch
from
0ad32e3 to
62a872c
Compare
Contributor
Author
done! |
Adds implementation of the `temporal worker deployment create` and `temporal worker deployment create-version` CLI commands using only direct gRPC API calls, not the sdk-go client code. Adds some basic unit tests for both commands though due to the server-side validation of proper AWS IAM credentials, the happy-path `temporal worker deployment create-version` call with AWS Lambda compute config is skipped until such time as we can figure out adding real AWS test fixtures. Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
The previous code placed mutating `temporal` CLI calls inside calls to `SharedServerSuite.EventuallyWithT`. This meant that calls to `temporal worker deployment create` or `temporal worker deployment create-version` were erroneously being retried in a tight loop. The asserting read-only calls such as `temporal worker deployment describe-version` are the things that need to be in the EventuallyWithT retrying closure, not the mutating calls. Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
jaypipes
force-pushed
the
jaypipes/serverless
branch
from
e985778 to
4096124
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds implementation of the
temporal worker deployment createandtemporal worker deployment create-versionCLI commands using only direct gRPC API calls, not the sdk-go client code.Adds some basic unit tests for both commands though due to the server-side validation of proper AWS IAM credentials, the happy-path
temporal worker deployment create-versioncall with AWS Lambda compute config is skipped until such time as we can figure out adding real AWS test fixtures.