Fix the http paths for the validate endpoints #95
Conversation
| rpc ValidateAccountAuditLogSink(ValidateAccountAuditLogSinkRequest) returns (ValidateAccountAuditLogSinkResponse) { | ||
| option (google.api.http) = { | ||
| post: "/cloud/account/audit-logs/sink/validate", | ||
| post: "/cloud/audit-log-sink/validate", |
There was a problem hiding this comment.
should this be "/cloud/account/audit-log-sink-validate"
There was a problem hiding this comment.
We decided to move audit logs into the root level.
There is no reason the audit logs sinks should be scoped under the account. All resources like namepspaces, apikeys, users etc are scoped to the account but the paths do not have a /account. We felt audit logs sinks should follow the same pattern.
There was a problem hiding this comment.
makes sense, so all the paths in this PR should be updated https://github.com/temporalio/cloud-api/pull/94/files
| rpc ValidateNamespaceExportSink(ValidateNamespaceExportSinkRequest) returns (ValidateNamespaceExportSinkResponse) { | ||
| option (google.api.http) = { | ||
| post: "/cloud/namespaces/{namespace}/export-sinks/validate", | ||
| post: "/cloud/namespaces/{namespace}/export-sink-validate", |
There was a problem hiding this comment.
QQ: validate is the function name? So we don't need /validate?
There was a problem hiding this comment.
The problem with "/cloud/namespaces/{namespace}/export-sinks/validate" is that it collides with an export sink with name "validate". This change is to avoid the collision.
No description provided.