EDU-1072: Clarify the key to be used to convert in PKCS8 for Java SDK#2301
Merged
flossypurse merged 2 commits intomainfrom Aug 25, 2023
Merged
EDU-1072: Clarify the key to be used to convert in PKCS8 for Java SDK#2301flossypurse merged 2 commits intomainfrom
flossypurse merged 2 commits intomainfrom
Conversation
djmagee
changed the title
flossypurse
approved these changes
Aug 25, 2023
flippedcoder
pushed a commit
that referenced
this pull request
May 4, 2026
…elds (#4526) * docs: relax host resource reporting requirement; refresh audit log fields - worker-health: drop the resource-based tuner requirement for host CPU/memory reporting and trim the Go SysInfoProvider example to a minimal worker.Options setup, matching how other SDKs document this. SysInfoProvider can now be set directly on worker.Options (sdk-go #2301). - audit-logs: remove the previously deprecated fields (user_email, level, caller_ip_address, details, category) from the format spec, deprecate request_id with a November 1 2026 removal target, and document async_operation_id as its replacement. * docs: call out sysinfo contrib import in host resource reporting example The trimmed example dropped the imports entirely, which obscured that sysinfo is a contrib package and needs to be pulled in explicitly. Add the relevant imports back to the snippet and a short prose note explaining why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To make it clear that the key to be converted to PKCS8 is the entity's private key.
Some users confused this with the CA key: https://temporalio.slack.com/archives/CTT84KXK9/p1692291446276049