EDU-4301: Add europe-west3, us-east4 psc service attachment ids#3500
Merged
fairlydurable merged 3 commits intomainfrom Apr 7, 2025
Merged
EDU-4301: Add europe-west3, us-east4 psc service attachment ids#3500fairlydurable merged 3 commits intomainfrom
fairlydurable merged 3 commits intomainfrom
Conversation
|
|
Contributor
|
@cludden Does gcpregions.md need updating too? Could it be done in this PR if yes? Also, is this information used anywhere else? File: docs/production-deployment/cloud/references/regions/gcpregions.md Thanks |
fairlydurable
changed the title
fairlydurable
added
the
cross-team
Member
Author
|
These aren't new regions, just including the relevant private service connect details. Unsure if it's used anywhere else. |
Contributor
|
Thank you @cludden! |
kevinkyyro
reviewed
May 30, 2025
Comment on lines
+61
to
+66
| | Region | Private Service Connect Service Name | | ||
| | -------------- | ------------------------------------------------------------------------------------------ | | ||
| | `asia-south1` | `projects/prod-d5spc2sfeshws33bg33vwdef7/regions/asia-south1/serviceAttachments/pl-7w7tw` | | ||
| | `europe-west3` | `projects/prod-kwy7d4faxp6qgrgd9x94du36g/regions/europe-west3/serviceAttachments/pl-acgsh` | | ||
| | `us-east4` | `projects/prod-y399cvr9c2b43es2w3q3e4gvw/regions/us-east4/serviceAttachments/pl-8awsy` | | ||
| | `us-west1 ` | `projects/prod-rbe76zxxzydz4cbdz2xt5b59q/regions/us-west1/serviceAttachments/pl-94w0x` | |
Contributor
There was a problem hiding this comment.
Asking just based on superficially seeing regions and "private service connect" in both places, but should https://github.com/temporalio/documentation/blob/main/docs/production-deployment/cloud/references/regions/private-service.md?plain=1 also contain the regions listed here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add europe-west3, us-east4 psc service attachment ids
Notes to reviewers