Add Nexus in Temporal TS SDK docs#3787
Merged
Merged
Conversation
dandavison
approved these changes
Aug 27, 2025
Minor copyedit changes
Adding sidebar item
prasek
requested changes
Aug 29, 2025
Contributor
prasek
left a comment
prasek
left a comment
There was a problem hiding this comment.
overall lgtm.
changes requested:
- added a suggested fix for one of the fixmes re: Protobuf JSON not supported by default.
- https://nexus-rpc.github.io/sdk-typescript links are 404, looks like those still need to be published
- cancelleation samples is inline and should be moved to samples-typescript, similar to https://github.com/temporalio/samples-java/tree/main/core/src/main/java/io/temporal/samples/nexuscancellation
Co-authored-by: Phil Prasek <prasek@gmail.com>
Fixing revised URL
brianmacdonald-temporal
approved these changes
Sep 5, 2025
Contributor
brianmacdonald-temporal
left a comment
brianmacdonald-temporal
left a comment
There was a problem hiding this comment.
Changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notes to reviewers