Skip to content

chore: account for underscore in branch name#4186

Merged
lennessyy merged 2 commits intomainfrom
preview-link-fix
Feb 5, 2026
Merged

chore: account for underscore in branch name#4186
lennessyy merged 2 commits intomainfrom
preview-link-fix

Conversation

@lennessyy
Copy link
Copy Markdown
Contributor

@lennessyy lennessyy commented Feb 5, 2026

What does this PR do?

  • Accounts for underscores in the branch name when generating preview links.

Vercel does this thing where if the github branch has the underscore in them, it doesn't include that in the URL but simply omits them. For example auto_migration_refactor actually yields https://temporal-documentation-git-automigrationrefactor.preview.thundergun.io/, not https://temporal-documentation-git-auto_migration_refactor.preview.thundergun.io/

Notes to reviewers

┆Attachments: EDU-5882 chore: account for underscore in branch name

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview, Comment Feb 5, 2026 6:14pm

Request Review

@lennessyy lennessyy marked this pull request as ready for review February 5, 2026 00:01
@lennessyy lennessyy requested a review from a team as a code owner February 5, 2026 00:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

📖 Docs PR preview links

This PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here.

@lennessyy lennessyy enabled auto-merge (squash) February 5, 2026 18:13
@lennessyy lennessyy merged commit 955784c into main Feb 5, 2026
10 checks passed
@lennessyy lennessyy deleted the preview-link-fix branch February 5, 2026 18:14
prasek pushed a commit to prasek/documentation that referenced this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants