Improve replay-safety documentation for interceptors, clarify where interceptors run.#4307
Merged
Improve replay-safety documentation for interceptors, clarify where interceptors run.#4307
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tconley1428
reviewed
Mar 19, 2026
| current_time = workflow.now() | ||
| ``` | ||
|
|
||
| #### Detecting replay (advanced) |
Contributor
There was a problem hiding this comment.
This is probably the right place to also elaborate on workflow.unsafe.is_replaying_history_events
Contributor
Author
There was a problem hiding this comment.
It doesn't seem to be in every SDK yet but I can add to the ones it's in. If you can ping the person who's implementing these to know to come update the docs, that'd be great.
tconley1428
reviewed
Mar 19, 2026
xumaple
reviewed
Mar 19, 2026
drewhoskins-temporal
force-pushed
the
drewhoskins_interceptor
branch
from
df1e65b to
f972671
Compare
Contributor
📖 Docs PR preview links
|
drewhoskins-temporal
changed the title
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Review of Ruby section
drewhoskins-temporal
force-pushed
the
drewhoskins_interceptor
branch
from
3ab1da7 to
c440108
Compare
jmaeagle99
reviewed
Mar 20, 2026
Contributor
jmaeagle99
left a comment
jmaeagle99
left a comment
There was a problem hiding this comment.
Feedback on improving links for .NET. Also, there is no interceptors docs for .NET, but looks like we have an issue for it already: #3875
Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com>
drewhoskins-temporal
force-pushed
the
drewhoskins_interceptor
branch
from
c440108 to
58190c8
Compare
Co-authored-by: Justin Anderson <44687433+jmaeagle99@users.noreply.github.com>
Co-authored-by: Justin Anderson <44687433+jmaeagle99@users.noreply.github.com>
Co-authored-by: Justin Anderson <44687433+jmaeagle99@users.noreply.github.com>
lennessyy
approved these changes
Mar 23, 2026
| #### Detecting replay (advanced) | ||
|
|
||
| Use [`workflow.IsReplaying(ctx)`](https://pkg.go.dev/go.temporal.io/sdk/workflow#IsReplaying) to guard code that should only run on the first execution, such as emitting metrics or sending external notifications from an Interceptor. | ||
| (Never use this to affect Workflow business logic - branching on replay status breaks determinism.) |
Contributor
There was a problem hiding this comment.
I'd put this in a Caution box instead
| #### Detecting replay (advanced) | ||
|
|
||
| Use [`WorkflowUnsafe.isReplaying()`](https://www.javadoc.io/doc/io.temporal/temporal-sdk/latest/io/temporal/workflow/WorkflowUnsafe.html) to guard code that should only run on the first execution, such as emitting metrics or sending external notifications from an Interceptor. | ||
| (Never use this to affect Workflow business logic - branching on replay status breaks determinism.) |
Contributor
There was a problem hiding this comment.
Same here for the rest of the SDKs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We're trying to improve our interceptor docs for our AI Partner program. Interceptors are hard, we're trying to make it easier.
Notes to reviewers
Main Claude Prompt:
Test plan:
click in all the docs
http://localhost:3000/develop/java/core-application#workflow-logic-requirements
http://localhost:3000/develop/dotnet/core-application#workflow-logic-requirements
http://localhost:3000/develop/python/core-application#workflow-logic-requirements
http://localhost:3000/develop/java/core-application#workflow-logic-requirements
http://localhost:3000/develop/go/core-application#workflow-logic-requirements
http://localhost:3000/develop/dotnet/core-application#workflow-logic-requirements
┆Attachments: EDU-6066 Improve replay-safety documentation for interceptors