Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
long-nt-tran
changed the title
long-nt-tran
force-pushed
the
long/go-nexus-quickstart
branch
from
6e5915b to
d59d330
Compare
long-nt-tran
force-pushed
the
long/go-nexus-quickstart
branch
from
d59d330 to
bb3ffff
Compare
long-nt-tran
force-pushed
the
long/go-nexus-quickstart
branch
from
bb3ffff to
9e45fd2
Compare
long-nt-tran
force-pushed
the
long/go-nexus-quickstart
branch
from
9e45fd2 to
ada6146
Compare
|
|
S15
reviewed
Apr 1, 2026
S15
left a comment
S15
left a comment
There was a problem hiding this comment.
One minor suggestion, but otherwise lgtm
Comment on lines
+336
to
+338
| Since you already installed the Go SDK from the [Go SDK Quickstart](/develop/go/set-up-your-local-go), the Nexus SDK | ||
| is already installed transitively. All you need to do now is to synchronize the dependencies based on the newly added | ||
| Nexus Operation by running: |
There was a problem hiding this comment.
this preamble reads a little awkwardly to me, I would maybe just drop it, and go straight into go mod tidy
Contributor
Author
There was a problem hiding this comment.
Makes sense, I made it slightly less wordy to be in line with the other instructions for running the worker and caller code
long-nt-tran
force-pushed
the
long/go-nexus-quickstart
branch
from
ada6146 to
324d57e
Compare
KeithB-Temporal
approved these changes
Apr 2, 2026
Contributor
KeithB-Temporal
left a comment
KeithB-Temporal
left a comment
There was a problem hiding this comment.
Changes look good pending a few consistency changes.
long-nt-tran
force-pushed
the
long/go-nexus-quickstart
branch
from
324d57e to
b4b823a
Compare
jsundai
approved these changes
Apr 3, 2026
Contributor
|
Great work! Will take one final look sometime today and get it merged. |
Contributor
|
I'll have to make a follow up PR for the Python and Java PRs to make sure how the links are handled are consistent and add to vercel.json. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a Quick Start guide for the Go SDK for Nexus.
It also moves the existing Nexus Setup for Go under a "Temporal Nexus" sidebar alongside the newly added page.
┆Attachments: EDU-6145 Add Nexus Go SDK quickstart
Note to reviewer
Preview to the newly added file is at https://temporal-documentation-git-long-go-nexus-quickstart.preview.thundergun.io/develop/go/nexus/quickstart