Specify additional dependencies with Ruby build#809
Merged
Conversation
THardy98
force-pushed
the
sdkbuild/ruby-local-path-gems
branch
from
f9bab19 to
4068cad
Compare
chris-olszewski
approved these changes
Apr 27, 2026
| gemspec path: %q | ||
| `, version, sourceDir) | ||
| } else { | ||
| // No version constraint — Bundler resolves to latest from RubyGems |
Member
There was a problem hiding this comment.
Was dropping support for temporalio without a version constraint intetional?
Contributor
Author
There was a problem hiding this comment.
Ah, so we're not dropping support for this, it's just that the code to do this is no longer in the conditional:
gemfileLines := []string{`source "https://rubygems.org"`, ""}
... branch conditionals where `version` is specified...
gemfileLines = append(gemfileLines, fmt.Sprintf(`gemspec path: %q`, sourceDir), "")
because we did the same thing regardless of which conditional branch we went down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
DWISOTT
Why?
Allows support of arbitrary dependencies, including local dependencies.