Add min-throughput-per-hour option for throughput_stress#232
Merged
Conversation
THardy98
changed the title
--min-workflows-completed flag configured in throughput_stress--min-throughput-per-hour flag configured in throughput_stress
Sushisource
reviewed
Oct 20, 2025
Comment on lines
+89
to
+90
| "Minimum workflow throughput required (workflows/hour, default: 0, disabled). "+ | ||
| "Only scenarios that implement this check will enforce it (currently: throughput_stress)") |
Member
There was a problem hiding this comment.
This should probably be added as a scenario specific flag (at least for now) -- see the flag consts at the top of throughputstress
Contributor
Author
There was a problem hiding this comment.
Sure - figured it might be useful to generally have and noop on other scenarios, don't mind either way
Member
There was a problem hiding this comment.
Yeah, I agree if/when we add it to others.
THardy98
changed the title
--min-throughput-per-hour flag configured in throughput_stressmin-throughput-per-hour option for throughput_stress
stephanos
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added a
min-throughput-per-houroption forthroughput_stressThis can be used as criteria to determine whether a scenario succeeds or not.For example, expecting 'x' number of workflows to completed within a certain amount of time.
Why?
Provides the ability to run
throughput_stresswith work-based criteria.