Skip to content

Various fixes for TS worker's kitchen sink/throughput stress workflow#235

Merged
THardy98 merged 1 commit intomainfrom
fix-ts-worker
Oct 23, 2025
Merged

Various fixes for TS worker's kitchen sink/throughput stress workflow#235
THardy98 merged 1 commit intomainfrom
fix-ts-worker

Conversation

@THardy98
Copy link
Copy Markdown
Contributor

@THardy98 THardy98 commented Oct 23, 2025

What was changed

Various fixes for TS worker's kitchen sink/throughput stress workflow

  • set correct activity timeout values (no 0 values)
  • add search attributes to child workflows so visibility check passes
  • fix pass through payload converter to simply pass through payloads (was breaking on its fromPayload path because no encoding was set, and it did not keep what encoding the payload was prior to encoding. But we don't need to encode at all 😃)

Why?

Allows usage of TS worker when running throughput_stress. To be used for future smoke/stress testing.

  1. How was this tested:
    Able to run:
go run ./cmd run-scenario-with-worker \
    --scenario throughput_stress \
    --language typescript \
    --iterations 10 \
    --option internal-iterations=10

which failed before

  1. Any docs updates needed?
    No

…s workflow:

- set correct activity timeout values (no 0 values)
- add search attributes to child workflows so visibility check passes
- fix pass through payload converter to simply pass through payloads (no need to encode)
@THardy98 THardy98 requested a review from a team as a code owner October 23, 2025 19:47
Copy link
Copy Markdown
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@THardy98 THardy98 merged commit d55d302 into main Oct 23, 2025
28 checks passed
@THardy98 THardy98 deleted the fix-ts-worker branch October 23, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants