Conversation
stephanos
force-pushed
the
remove-fairness-validation
branch
from
ba15949 to
b09510b
Compare
stephanos
force-pushed
the
remove-fairness-validation
branch
from
b09510b to
c9d06bf
Compare
dnr
reviewed
Oct 25, 2025
| // Set fairness, if specified | ||
| fairnessKey := activity.GetFairnessKey() | ||
| fairnessWeight := activity.GetFairnessWeight() | ||
| if fairnessKey != "" { |
Contributor
There was a problem hiding this comment.
we need fairness keys though.. put it in the real field now that it's released
Collaborator
Author
There was a problem hiding this comment.
I'd need to update the SDK to use the real field now.
dnr
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Remove fairness validation from ebb and flow scenario.
Why?
Suspected memory leak. And it's not really used anyway.
Checklist
Closes
How was this tested: