Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
THardy98
force-pushed
the
feat/typescript-harness
branch
from
744a2e0 to
7ad47d6
Compare
Sushisource
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds
typescript/harness/package, effectively a port of the same Python harness (python/harness).typescript/harnessis a standalone Typescript package that supports the same harness semantics, structure, and API as the existing Python harness. The test suite (typescript/harness/tests) similarly mimics the existing Python harness test suite.A couple changes that are Typescript-specific:
workers/typescriptpackage now usesnpm workspaces. This is so that we can enforce the sametemporalioversion between the test and the harness, which are separate Typescript packages.protogen.jsandgrpc-helpers.tsexist to generate protobuf types and grpc helpers that the Typescript harness consumes (In contrast, Python commits the generated proto. The Typescript kitchensink protos were already generated on the fly, I stuck with that pattern for the harness protos)Why?