Skip to content

Fix Python worker prometheus exporter#71

Merged
dandavison merged 1 commit intotemporalio:mainfrom
dandavison:fix-python
Jan 26, 2024
Merged

Fix Python worker prometheus exporter#71
dandavison merged 1 commit intotemporalio:mainfrom
dandavison:fix-python

Conversation

@dandavison
Copy link
Copy Markdown
Contributor

The prometheus server is started by the core bridge nowadays. This PR gets rid of some draft code we had that was starting a server directly in Python. Without this PR there are errors in the python code and a port conflict that can be reproduced with

docker build -f dockerfiles/python.Dockerfile -t omes-python .
docker run -e RUST_BACKTRACE=full omes-python \
        --scenario workflow_with_single_noop_activity \
        --run-id local-test-run \
        --language python \
        --namespace default \
        --server-address=host.docker.internal:7233 \
        --worker-prom-listen-address=127.0.0.1:9090

@dandavison dandavison merged commit a91f131 into temporalio:main Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants