Skip to content

bug(timeout): increase workflow pool timeout#74

Merged
rustatian merged 2 commits intomasterfrom
bug/small_timeout
Jun 24, 2021
Merged

bug(timeout): increase workflow pool timeout#74
rustatian merged 2 commits intomasterfrom
bug/small_timeout

Conversation

@rustatian
Copy link
Copy Markdown
Collaborator

Reason for This PR

closes: #73

Description of Changes

  • Increase timeout to 10 days (inf in terms of processing workers tasks).

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added B-bug Bug: bug, unhandled exception C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. beta-nominated Nominated for backporting to the RR-Temporal in the beta channel. labels Jun 24, 2021
@rustatian rustatian added this to the v1.0.8 milestone Jun 24, 2021
@rustatian rustatian self-assigned this Jun 24, 2021
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #74 (148a728) into master (9e6bf02) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   66.46%   66.63%   +0.17%     
==========================================
  Files          16       16              
  Lines         978      983       +5     
==========================================
+ Hits          650      655       +5     
  Misses        236      236              
  Partials       92       92              
Impacted Files Coverage Δ
activity/activity_pool.go 75.00% <ø> (ø)
workflow/worker.go 81.15% <100.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6bf02...148a728. Read the comment docs.

@rustatian rustatian requested a review from wolfy-j June 24, 2021 11:28
@rustatian rustatian changed the title bug(timeout): increase worflow pool timeout bug(timeout): increase workflow pool timeout Jun 24, 2021
@rustatian rustatian merged commit bb7cc73 into master Jun 24, 2021
@rustatian rustatian deleted the bug/small_timeout branch June 24, 2021 11:30
@rustatian rustatian mentioned this pull request Jun 30, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-bug Bug: bug, unhandled exception beta-nominated Nominated for backporting to the RR-Temporal in the beta channel. C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 60 seconds rescheduling time when processing many workfows at once

3 participants