Add liveness reporting for the yamux observer#101
Merged
temporal-nick merged 3 commits intomainfrom Jun 24, 2025
Merged
Conversation
temporal-nick
force-pushed
the
nick/fixes
branch
from
802ef62 to
3e80ebd
Compare
pglass
approved these changes
Jun 24, 2025
hehaifengcn
reviewed
Jun 24, 2025
| // This is an async monitor. Don't let it crash the rest of the program if there's a problem | ||
| recover() | ||
| err := recover() | ||
| logger.Warn("Yamux observer died!", tag.NewStringTag("muxConfigName", config.Name), tag.NewAnyTag("err", err)) |
Collaborator
There was a problem hiding this comment.
I would just use error as normally we just query error logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
On panic, log a warning containing whatever went wrong
Why?
If there's any panic-errors, it would be good to have a log line describing what happened. Followup to #97 (comment)