Vendor gogo-based protos and serializer from Temporal v1.22.2#117
Merged
Vendor gogo-based protos and serializer from Temporal v1.22.2#117
Conversation
1 task
| cat <<EOF > "$out_file" | ||
| # Overview | ||
|
|
||
| This is a partial copy of [${repo} at ${commit}](${tree_link}) |
Collaborator
There was a problem hiding this comment.
Would be good to also explain why we're copying this.
"Temporal 1.22 used gogo-protobuf for serialization, which allowed it to store invalid UTF8 provided from the SDK and workers locally. Temporal 1.23 switched to google-protobuf, which requires all string data be valid UTF8. The proxy uses these proto definitions to seamlessly repair broken UTF8 strings in flight without dropping any of the valid data. "
temporal-nick
approved these changes
Jul 10, 2025
Collaborator
temporal-nick
left a comment
temporal-nick
left a comment
There was a problem hiding this comment.
One minor comment on the README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Copy over protos and certain code from version v1.22.2 of Temporal server into the
protos/1_22directory. This includes generated protobuf code from temporalio/api-go and temporalio/temporal, and the serializer.Add the
make vendor-protostarget, which runs thedevelop/vendor-protos.shscript, which clones and copies the files and is repeatable/idempotent.Why?
We will use these gogo-based protos to repair invalid UTF-8. Merge these first to declutter the subsequent PRs.
Checklist
Closes
How was this tested: