Merged
Conversation
temporal-nick
approved these changes
Aug 19, 2025
| i.logger.Debug("InterceptStream", tag.NewAnyTag("method", info.FullMethod)) | ||
| err := handler(srv, newStreamTranslator(ss, i.logger, i.translators)) | ||
| if err != nil { | ||
| i.logger.Error("grpc handler with error: %v", tag.Error(err)) |
Collaborator
There was a problem hiding this comment.
Is this log still valuable if it's behind a throttle that restricts it to 1/min?
Contributor
Author
There was a problem hiding this comment.
My guess is not? I think in general the error is usually just EOF.
Also, if it is valuable, we should log this gRPC error in a spot that is always enabled (not just when the translation interceptor is enabled)
Contributor
Author
There was a problem hiding this comment.
I do think we should tune the log throttle to be component-based (and maybe have component-based log settings)
hai719
pushed a commit
to hai719/s2s-proxy
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This cleans up some logging calls.
log.Withon a per-request path since it allocatesWhy?
Tidy up our logging a bit.
Checklist
Closes
How was this tested: