Merged
Conversation
temporal-nick
approved these changes
Aug 19, 2025
client/temporal_client.go
Outdated
| // Create admin client | ||
| c.adminClientsLock.Lock() | ||
| defer c.adminClientsLock.Unlock() | ||
| c.adminClientsLock.Lock() |
Collaborator
There was a problem hiding this comment.
If this method is super-high-throughput, we can use double-checked initialization here:
if c.adminClient != nil {
return c.adminClient
}
c.adminClientsLock.Lock()
defer c.adminClientsLock.Unlock()
if c.adminClient != nil {
return c.AdminClient
}
...
hai719
pushed a commit
to hai719/s2s-proxy
that referenced
this pull request
Nov 24, 2025
* fix: ClientProvider locking * Double-checked lock --------- Co-authored-by: Nick Beaumont <nicholas.beaumont@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Correct lock usage to create only one client of a particular type.
Why?
The current logic is not quite thread-safe. It allows many clients to be created when the proxy server is first (re)started, depending on how many requests come in. This is probably not harmful but results in a bunch of unnecessary clients, as well as a confusing metric that indicates many yamux streams are being used.
Checklist
Closes
How was this tested:
Existing unit tests